Remove autdated ASSERT fixing #13164 - #13165
Merged
Merged
Conversation
Member
Author
|
cleaning up the 2.4.1 milestone from this hard to reproduce issue |
acolombier
reviewed
Jun 10, 2024
| // FIXME: This should never happen but it does. But why?? | ||
| return QVariant(); | ||
| } | ||
| VERIFY_OR_DEBUG_ASSERT(siblingColumn != index.column()) { |
Member
There was a problem hiding this comment.
Should this be replaced with a if instead of removing the condition check entirely like above? Reading the comment, since it seems the early return was here to prevent infinite recursion. Or is that comment incorrect/out of date?
Member
Author
|
I have made rawValue() pure virtual to show that we have no infinitive recursive call issue. |
Member
Author
|
@Swiftb0y merge? |
Member
|
I guess 🤷 |
Member
|
I could repro it finally and verify the fix! (with the location column I guess) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13164